Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional issues #159

Merged
merged 5 commits into from
Jan 26, 2020
Merged

Regional issues #159

merged 5 commits into from
Jan 26, 2020

Conversation

antaldaniel
Copy link
Contributor

Apologies, I made this PR to master.... Re-do it with devel.

Identify mis-labelled observations
Recode where there were no boundary changes
Detect discontinued regions
Give guideance on further correspondence possibilities.
They need to import two new data frames with the helper function in data-raw.

I added a short description to each file. Unfortunately, I cannot fully run the tests in Windows locally with devtool, I do not understand why, but I think that the files are correct.

So, please, first create the new files in the data-raw, import the data files needed for detecting issues,
then go on with the new helper functions.

If these work, I will add some more with a long-form documentation in an article.

… labels.

The download.file () call is tested on a Windows machine, please check if the data file is correctly created.  (The data file needs to be exported only to the package, not this helper function.)
creates two new internal data frames for the package.

These are used to identify potentially wrong geo labelling, and for correcting them, whenever possible.
…s affected by the incorrect labelling of regional geo codes.

Because the already imported example data frame tgs00026 is affected, it can be used for testing and examples.
…d it identifies other problematic labels for further treatment. The further treatment will be later added with an article, because it is is not always very straightforward.

Because the already imported example data frame tgs00026 is affected, it can be used for testing and examples.
@antaldaniel antaldaniel merged commit 5baa23c into rOpenGov:devel Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant