Fix preprocessor options for MSVC, so assert works

rHermes · May 5, 2024 · bcfd298 · bcfd298
1 parent 1f292a1
commit bcfd298
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/include/hage/core/assert.hpp b/include/hage/core/assert.hpp
@@ -2,6 +2,7 @@
 
 #include "misc.hpp"
 
+#include <stdexcept>
 #include <string_view>
 #include <utility>
 

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -79,7 +79,11 @@ foreach (target_var IN ITEMS hage_atomic hage_logging hage_core)
 
 
     if (MSVC)
-        target_compile_options(${target_var} ${priv_type} /W4 /utf-8 /permissive- /Zc:__cplusplus)
+        target_compile_options(${target_var} ${priv_type} /W4 /utf-8)
+
+        # These options make msvc act sane.
+        # This is to make sure that the new preprocessor is chosen, which is required
+        target_compile_options(${target_var} ${pub_type} /permissive- /Zc:__cplusplus /Zc:preprocessor)
     else ()
         target_compile_options(${target_var} ${priv_type} -Wall -Wextra -Wpedantic)