Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add build-system requires cmake #60

Merged
merged 1 commit into from
Jul 28, 2023
Merged

ENH: add build-system requires cmake #60

merged 1 commit into from
Jul 28, 2023

Conversation

sabonerune
Copy link
Contributor

Add cmake to your build-system requirements.

This solves Build fails if pip's cmake is installed.
And it will be able to build even if cmake is not installed.

r9y9
r9y9 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍

@r9y9 r9y9 merged commit d55dd81 into r9y9:master Jul 28, 2023
@sabonerune sabonerune deleted the enh/add-req-cmake branch July 28, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r9y9 r9y9 r9y9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sabonerune @r9y9