Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo design #76

Closed
jraulhernandezi opened this issue Apr 26, 2018 · 9 comments
Closed

Logo design #76

jraulhernandezi opened this issue Apr 26, 2018 · 9 comments

Comments

@jraulhernandezi
Copy link
Contributor

Hi, are interested in having a logo for you project? I could send you some ideas if you like.

@r9y9
Copy link
Owner

r9y9 commented Apr 27, 2018

I haven't thought about logo but yeah it would be nice to have. I'm happy to your suggestions.

@jraulhernandezi
Copy link
Contributor Author

I´m working on it, the typography should be Pytorch, or Deepvoice 3 Pytorch?

@r9y9
Copy link
Owner

r9y9 commented Apr 27, 2018

Deep Voice 3 Pytorch sounds good to me.

https://arxiv.org/abs/1710.07654

@jraulhernandezi
Copy link
Contributor Author

What do you think about this one?, I used a wave sound figure inside a form inspired on the PyTorch Logotype.

image

@r9y9
Copy link
Owner

r9y9 commented Apr 28, 2018

Cool!

@r9y9
Copy link
Owner

r9y9 commented Apr 28, 2018

Would you mind creating a PR that puts the logo into README and https://github.com/r9y9/deepvoice3_pytorch/blob/master/docs/static/favicon.png?

EDIT:

<div class="container">
<header role="banner">
<div class="header-logo">
<a href="/"><img src="{{ .Site.Params.logo }}" width="70" height="70"></a>
</div>
{{ if eq $isHomePage true }}<h1 class="site-title">{{ .Site.Title }}</h1>{{ end }}
</header>
and
logo = "/images/r9y9.jpg"
also need to be adjusted. I can fix them if you could leave it to me.

@jraulhernandezi
Copy link
Contributor Author

Ok, i´m on it!

r9y9 added a commit that referenced this issue Apr 29, 2018
r9y9 added a commit that referenced this issue Apr 29, 2018
@r9y9
Copy link
Owner

r9y9 commented Apr 29, 2018

https://r9y9.github.io/deepvoice3_pytorch/ the project page updated. Thank you very much, @jraulhernandezi.

@r9y9
Copy link
Owner

r9y9 commented May 3, 2018

I'm closing the issue. Thanks again

@r9y9 r9y9 closed this as completed May 3, 2018
engiecat pushed a commit to engiecat/deepvoice3_pytorch that referenced this issue May 5, 2018
engiecat pushed a commit to engiecat/deepvoice3_pytorch that referenced this issue May 5, 2018
engiecat pushed a commit to engiecat/deepvoice3_pytorch that referenced this issue May 5, 2018
engiecat pushed a commit to engiecat/deepvoice3_pytorch that referenced this issue May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants