client: reconnect after an EOF #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcdawkins
force-pushed
the
eof-error
branch
from
4bcb6c8 to
a3b4b97
Compare
|
If implementing a client running long-term expected to go through many reconnections, you would probably also want #152 |
tobias-urdin
added a commit
to tobias-urdin/sse
that referenced
this pull request
Feb 23, 2023
sergey-cheperis
added a commit
to sergey-cheperis/sse
that referenced
this pull request
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147
Removes the special case for EOF errors, so that a client will reconnect when the stream is closed with an EOF.
Edit: this is almost a duplicate of #145 / #75 - although that keeps the old behavior by default, with an
AutoReconnectflag. I am not sure why the default behavior is desirable (the conversation could happen in any of those issues). (So if this PR is preferred, it closes #75 and closes #145)