Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context cancelled should be respected #131

Open
ss89 opened this issue Apr 24, 2022 · 3 comments · May be fixed by #146
Open

Context cancelled should be respected #131

ss89 opened this issue Apr 24, 2022 · 3 comments · May be fixed by #146

Comments

@ss89
Copy link

ss89 commented Apr 24, 2022

SubscribeWithContext and SubscribeChanWithContext should respect if the passed context got cancelled and by definition return that error. Am i wrong?
peteut added a commit to peteut/sse that referenced this issue Apr 27, 2022
@peteut
client: fix context handling.
1f7e179 
* fixes r3labs#131.
@peteut
Copy link

peteut commented Apr 27, 2022

Bumped into this as well. This should fix it: peteut@1f7e179 .

@brianmcgee
Copy link

Hitting this issue aswell.

wwade pushed a commit to wwade/sse that referenced this issue Jan 24, 2023
@wade-arista
client: pass the provided ctx to backoff.RetryNotify
fe8f773 
If we hit a connection error in any of the ..WithContext functions, we
end up blocked in the backoff.RetryNotify loop. This loop can use a
context, but it needs to be bound to the BackOff provided when
RetryNotify is called.

Added a test case `TestSubscribeWithContextAbortRetrier` to
demonstrate the problem and verify the fix.

Fixes r3labs#131.
wwade pushed a commit to wwade/sse that referenced this issue Jan 24, 2023
@wade-arista
client: pass the provided ctx to backoff.RetryNotify
e92da53 
If we hit a connection error in any of the ..WithContext functions, we
end up blocked in the backoff.RetryNotify loop. This loop can use a
context, but it needs to be bound to the BackOff provided when
RetryNotify is called.

Added a test case `TestSubscribeWithContextAbortRetrier` to
demonstrate the problem and verify the fix.

Fixes r3labs#131.
@wwade wwade linked a pull request Jan 24, 2023 that will close this issue
Open
@bogdanprodanj
Copy link

Any ETA on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: pass the provided ctx to backoff.RetryNotify wwade/sse
4 participants
@brianmcgee @peteut @ss89 @bogdanprodanj