-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - animated 2Ds showing transition between 2D structures from PDB files #163
base: develop
Are you sure you want to change the base?
Conversation
Thank you very much Tomasz! I will check it out and get back to you in the next few days! 🚀 Fix #146 |
I left some first comments - I am building the image locally and will test it in more detail. Thank you for working on this Tomasz! Exciting times! ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fryzjergda Tomasz, this is really good, thank you so much for your great work! I tried it and it mostly works as expected (except for one test).
I left some minor comments - once addressed, this can be merged and ready to go. Many thanks for such a clean PR! Looking forward to seeing this be part of core R2DT. 👏👏👏
self.check_examples() | ||
|
||
|
||
class TestAnimateBulk(R2dtTestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add a test case for non-bulk animation as well?
Similar to this command from the docs:
python3 utils/animate3d.py \
examples/PZ1_solution_0.pdb \
examples/PZ1_Bujnicki_1.pdb \
examples/PZ1_solution_0_to_PZ1_Bujnicki_1.animated.svg
Summary
Changes Made
TestRnaview
to validate generation of secondary structure diagram from PDB.TestAnimateBulk
to validate animation from PDBs.Testing
Notes