Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api/nonfungibles): benchmarking #384

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Nov 14, 2024

  • read weights and unit testing
  • approve_transfer
  • destroy
  • cancel_approval

@chungquantin chungquantin changed the title feat(partially): stata read benchmarking feat(partially): state read benchmarking Nov 14, 2024
@chungquantin chungquantin self-assigned this Nov 14, 2024
@chungquantin chungquantin changed the title feat(partially): state read benchmarking feat(api/nonfungibles): state read benchmarking Nov 14, 2024
@chungquantin chungquantin force-pushed the chugnquantin/feat-nonfungibles/read_weights branch from 5296af0 to aab9700 Compare November 16, 2024 06:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 59.10596% with 247 lines in your changes missing coverage. Please review.

Project coverage is 71.38%. Comparing base (a78d717) to head (20ff91d).

Files with missing lines Patch % Lines
pallets/nfts/src/weights.rs 3.40% 170 Missing ⚠️
pallets/api/src/nonfungibles/weights.rs 50.00% 64 Missing ⚠️
pallets/api/src/nonfungibles/benchmarking.rs 0.00% 5 Missing ⚠️
pallets/nfts/src/benchmarking.rs 80.95% 2 Missing and 2 partials ⚠️
pallets/api/src/nonfungibles/mod.rs 89.47% 0 Missing and 2 partials ⚠️
pallets/api/src/nonfungibles/tests.rs 99.20% 1 Missing and 1 partial ⚠️
@@                                      Coverage Diff                                      @@
##           chugnquantin/feat-nonfungibles/destroy_collection_weights     #384      +/-   ##
=============================================================================================
+ Coverage                                                      70.87%   71.38%   +0.50%     
=============================================================================================
  Files                                                             72       74       +2     
  Lines                                                          12970    13370     +400     
  Branches                                                       12970    13370     +400     
=============================================================================================
+ Hits                                                            9193     9544     +351     
- Misses                                                          3496     3542      +46     
- Partials                                                         281      284       +3     
Files with missing lines Coverage Δ
pallets/nfts/src/lib.rs 72.06% <100.00%> (+0.11%) ⬆️
runtime/devnet/src/lib.rs 5.53% <ø> (ø)
pallets/api/src/nonfungibles/mod.rs 72.67% <89.47%> (+4.21%) ⬆️
pallets/api/src/nonfungibles/tests.rs 99.72% <99.20%> (-0.28%) ⬇️
pallets/nfts/src/benchmarking.rs 85.71% <80.95%> (-0.09%) ⬇️
pallets/api/src/nonfungibles/benchmarking.rs 0.00% <0.00%> (ø)
pallets/api/src/nonfungibles/weights.rs 50.00% <50.00%> (ø)
pallets/nfts/src/weights.rs 4.26% <3.40%> (+1.89%) ⬆️

@chungquantin chungquantin force-pushed the chugnquantin/feat-nonfungibles/read_weights branch from c0554c3 to 20ff91d Compare November 16, 2024 08:13
@chungquantin chungquantin force-pushed the chugnquantin/feat-nonfungibles/read_weights branch from 20ff91d to 6ecb1cf Compare November 16, 2024 10:43
@chungquantin chungquantin changed the title feat(api/nonfungibles): state read benchmarking feat(api/nonfungibles): benchmarking Nov 16, 2024
@chungquantin chungquantin merged commit 6d4febf into chugnquantin/feat-nonfungibles/destroy_collection_weights Nov 16, 2024
12 of 14 checks passed
@chungquantin chungquantin deleted the chugnquantin/feat-nonfungibles/read_weights branch November 16, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants