Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: timestamp settings for tests #347

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

Daanvdplas
Copy link
Collaborator

Required change for drink test environment. This PR has to be merged to have the reviewers test #300

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.60%. Comparing base (52fb7f0) to head (edb7b13).

@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   51.60%   51.60%           
=======================================
  Files          48       48           
  Lines        4910     4910           
  Branches     4910     4910           
=======================================
  Hits         2534     2534           
  Misses       2327     2327           
  Partials       49       49           
Files with missing lines Coverage Δ
runtime/devnet/src/lib.rs 5.53% <ø> (ø)

Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concern from my end!

@AlexD10S AlexD10S self-requested a review October 21, 2024 07:14
@Daanvdplas Daanvdplas merged commit f213164 into main Oct 21, 2024
12 checks passed
@Daanvdplas Daanvdplas deleted the daan/chore-timestamp_test branch October 21, 2024 07:41
@evilrobot-01
Copy link
Collaborator

I think we need to be mindful of benchmarks with something like this. Unlikely we will benchmark on devnet runtime tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants