-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add CI script for pop-api
tests and integration tests
#228
ci: add CI script for pop-api
tests and integration tests
#228
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## daan/api #228 +/- ##
============================================
+ Coverage 34.08% 34.10% +0.02%
============================================
Files 34 34
Lines 3013 3011 -2
Branches 3013 3011 -2
============================================
Hits 1027 1027
+ Misses 1954 1952 -2
Partials 32 32 |
Hmmm, could we not have solved this with a |
@evilrobot-01 Thanks for the feedback. I have redesigned the CI to simplify the script and move the contract build process to the cc: @Daanvdplas |
pop-api
tests and integration tests
Gave it a quick test and it failed as I did not specify the 'contracts' feature. Is there any reason that this needs to be specified explicitly? The goal is that we can just run cargo test in the integration tests folder and the build script will ensure that the contracts are built, as the integration tests are reliant on them being built. Running it again with the feature then worked, but it took a long time on 'building' after having cleared out the caches of all contracts and integration tests. Would outputting something to the console help here possibly? Just a message stating 'building xxx contract...' for each should be enough. |
Great job, this will be quite useful! It would be a nice addition to have all .wasms get outputted to an |
@peterwht Contracts are archived as artifacts |
Rebuilding contracts each time should be instant if no changes and ensures that any local contract changes are always included when running tests, improving our devex flow. In the past we had to know to run all these extra commands, now we just make changes and run the tests and everything 'just works' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Tin! Provided a suggested refactor.
Co-authored-by: Daan van der Plas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine and works as is. I personally dont see the need for storing the artifacts to would be interested to see how they will actually be used.
I still think that a console log per contract build would be better than nothing whatsoever, especially as we expect many more test contracts to be added in the near term.
Update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Daan van der Plas <[email protected]>
Co-authored-by: Daan van der Plas <[email protected]>
Link to issue: #109
integration-tests/contracts
when runningcargo build --features integration-tests