-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: token terminology #215
Conversation
935f99a
to
ebba6fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one trivial question.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## daan/api #215 +/- ##
=========================================
Coverage 42.59% 42.59%
=========================================
Files 47 47
Lines 4139 4139
Branches 4139 4139
=========================================
Hits 1763 1763
Misses 2319 2319
Partials 57 57
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor fixes required along with a few suggestions. Also needs conflicts resolving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor quick change then good to go!
No description provided.