Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: token terminology #215

Merged
merged 16 commits into from
Sep 9, 2024
Merged

Conversation

Daanvdplas
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one trivial question.

pallets/api/src/mock.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 95.75758% with 7 lines in your changes missing coverage. Please review.

Project coverage is 42.59%. Comparing base (c0ea3ed) to head (2538b96).
Report is 1 commits behind head on daan/api.

Files with missing lines Patch % Lines
pallets/api/src/fungibles/mod.rs 85.71% 7 Missing ⚠️
@@            Coverage Diff            @@
##           daan/api     #215   +/-   ##
=========================================
  Coverage     42.59%   42.59%           
=========================================
  Files            47       47           
  Lines          4139     4139           
  Branches       4139     4139           
=========================================
  Hits           1763     1763           
  Misses         2319     2319           
  Partials         57       57           
Files with missing lines Coverage Δ
pallets/api/src/fungibles/benchmarking.rs 100.00% <ø> (ø)
pallets/api/src/fungibles/tests.rs 100.00% <100.00%> (ø)
pallets/api/src/mock.rs 100.00% <ø> (ø)
primitives/src/lib.rs 0.00% <ø> (ø)
runtime/devnet/src/config/api/mod.rs 35.29% <ø> (ø)
pallets/api/src/fungibles/mod.rs 82.77% <85.71%> (ø)

Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes required along with a few suggestions. Also needs conflicts resolving.

pallets/api/src/fungibles/mod.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles.rs Show resolved Hide resolved
pop-api/src/v0/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor quick change then good to go!

primitives/src/lib.rs Outdated Show resolved Hide resolved
@evilrobot-01 evilrobot-01 merged commit 206757b into daan/api Sep 9, 2024
4 checks passed
@evilrobot-01 evilrobot-01 deleted the daan/style-token_terminology branch September 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants