refactor: migrate integration tests to paseo #139
Conversation
evilrobot-01
requested review from
Daanvdplas,
al3mart and
peterwht
and removed request for
Daanvdplas
Rococo runtime (sdk 1.7) used currency adapter (https://github.com/paritytech/polkadot-sdk/blob/09df373db9cd5dfed82c5cdb0736d417d54249e6/polkadot/runtime/rococo/src/xcm_config.rs#L77) whereas Paseo/Polkadot uses fungible adapter (https://github.com/paseo-network/runtimes/blob/e7265b10b28d8b82c3146e72c98895dac2b55729/relay/paseo/src/xcm_config.rs#L82C33-L82C48), resulting in different events being emitted.
evilrobot-01
force-pushed
the
frank/paseo-integration-tests
branch
from
f8ff45f
to
d116ab1
Compare
# Conflicts: # Cargo.lock # Cargo.toml
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #139 +/- ##
=====================================
Coverage 3.30% 3.30%
=====================================
Files 30 30
Lines 6843 6843
Branches 6843 6843
=====================================
Hits 226 226
Misses 6617 6617
|
There was a problem hiding this comment.
As mentioned, the RelayNetwork could be convenient to address now if we believe that we will hit that versioning constrain sometime soon. Note that Paseo follows Polkadot's enacted runtime versions.
That said, it should be most likely for Paseo to change its xcm configuration to use something as NetworkId::Paseo than a regenesis of the network.
|
I was more concerned whether using this value might one day cause sending xcm messages on a local testnet to fail, if the paseo-local relay genesis block is set by zombienet for example, based on some network configuration file. |
Whilst using ByGenesis is more accurate for the live paseo testnet, using this approach *may* prevent any local test networks from working, if zombienet config results in a different genesis block for example.
Migrates integration tests to use the Paseo runtime.
IMPORTANT NOTE: switching this dependency means we are effectively stuck on SDK 1.7 until Paseo updates. The runtimes at https://github.com/polkadot-fellows/runtimes have been updated to 1.13 recently in
main, but no release has been generated yet. Should we wish to update the SDK version we use, we can simply replace the paseo dependencies with the corresponding runtimes from https://github.com/polkadot-fellows/runtimes. I am doing this in another project for now.Closes #138