Skip to content

chore: upgrade to 1.13.0 #690

chore: upgrade to 1.13.0

chore: upgrade to 1.13.0 #690

Triggered via pull request August 17, 2024 04:52
@chungquantinchungquantin
synchronize #194
Status Success
Total duration 10s
Artifacts

lint-pr.yml

on: pull_request_target
Validate PR title for conventional commit compliance
3s
Validate PR title for conventional commit compliance
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
large size difference between variants: node/src/cli.rs#L5
warning: large size difference between variants --> node/src/cli.rs:5:1 | 5 | / pub enum Subcommand { 6 | | /// Build a chain specification. 7 | | BuildSpec(sc_cli::BuildSpecCmd), ... | 19 | | ImportBlocks(sc_cli::ImportBlocksCmd), | | ------------------------------------- the second-largest variant contains at least 240 bytes ... | 39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd), | | ----------------------------------------------- the largest variant contains at least 544 bytes ... | 43 | | Key(sc_cli::KeySubcommand), 44 | | } | |_^ the entire enum is at least 544 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this match could be replaced by its body itself: runtime/testnet/src/extensions.rs#L180
warning: this match could be replaced by its body itself --> runtime/testnet/src/extensions.rs:180:15 | 180 | let result = match key { | __________________^ 181 | | _ => Vec::<u8>::default(), 182 | | } | |_____^ help: consider using the match body instead: `Vec::<u8>::default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding = note: `#[warn(clippy::match_single_binding)]` on by default
this match could be replaced by its body itself: runtime/devnet/src/extensions.rs#L180
warning: this match could be replaced by its body itself --> runtime/devnet/src/extensions.rs:180:15 | 180 | let result = match key { | __________________^ 181 | | _ => Vec::<u8>::default(), 182 | | } | |_____^ help: consider using the match body instead: `Vec::<u8>::default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding = note: `#[warn(clippy::match_single_binding)]` on by default
bound is defined in more than one place: runtime/testnet/src/extensions.rs#L32
warning: bound is defined in more than one place --> runtime/testnet/src/extensions.rs:32:10 | 32 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError> | ^ 33 | where 34 | E: Ext<T = T>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
bound is defined in more than one place: runtime/devnet/src/extensions.rs#L32
warning: bound is defined in more than one place --> runtime/devnet/src/extensions.rs:32:10 | 32 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError> | ^ 33 | where 34 | E: Ext<T = T>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
unexpected `cfg` condition value: `metadata-hash`: runtime/testnet/build.rs#L8
warning: unexpected `cfg` condition value: `metadata-hash` --> runtime/testnet/build.rs:8:32 | 8 | #[cfg(all(feature = "std", not(feature = "metadata-hash")))] | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `runtime-benchmarks`, `std`, and `try-runtime` = help: consider adding `metadata-hash` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `metadata-hash`: runtime/testnet/build.rs#L1
warning: unexpected `cfg` condition value: `metadata-hash` --> runtime/testnet/build.rs:1:28 | 1 | #[cfg(all(feature = "std", feature = "metadata-hash"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `default`, `runtime-benchmarks`, `std`, and `try-runtime` = help: consider adding `metadata-hash` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default