-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace rococo to paseo name #333
Conversation
Thank you for your contribution! Really cool. I run the CI to run all the unit and integration tests and are failing. Let me investigate it. |
Thank you for reviewing this PR. I believe I've identified the issue, which originates from the It seems that Zombienet only supports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CocDap I’ve rerun the integration tests after the Paseo v1.3.3 release, and it looks like the issue is resolved ,thanks for your patience!
However, the unit tests still need some adjustments. I left a comment about the chain_spec_generator_returns_none_when_no_match
test you changed.
And the other one it will need adjustment is binaries_works
(https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-parachains/src/up/mod.rs#L1238), note that the Paseo chain spec generators are now binaries we are fetching increasing the binaries count to 6 instead of 4. Just change the following line(https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-parachains/src/up/mod.rs#L1272), to:
assert_eq!(zombienet.binaries().count(), 6);
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 70.33% 70.47% +0.14%
==========================================
Files 53 54 +1
Lines 9098 9250 +152
Branches 9098 9250 +152
==========================================
+ Hits 6399 6519 +120
- Misses 1718 1737 +19
- Partials 981 994 +13
... and 12 files with indirect coverage changes 🚨 Try these New Features:
|
It seems that the |
Thanks for the changes. I don't think is anything you have to change in the code, and more the chain generator of Paseo. I am going to investigate why only fails in |
Fixed! Thanks again fro contributing @CocDap |
Relevant issue: #322
Two manually check on local:
pop new parachain my-para
. Check relay chain is paseo runtime on the polkadot js explorer ✅cargo test
❌P/S: I am very happy to contribute for the first time to this project