Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: templates errors #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: templates errors #329

wants to merge 1 commit into from

Conversation

AlexD10S
Copy link
Collaborator

Closes #323. For the contract_template's cross-contract-calls, it was necessary to rename e2e_tests.rs to match the user-defined input name. Without this adjustment, the e2e tests would fail due to the file not being correctly recognized.

Closes #321 using the PSP34 managed by R0gue: https://github.com/r0gue-io/PSP34

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.37%. Comparing base (2af82eb) to head (e2b0cf0).

Files with missing lines Patch % Lines
crates/pop-contracts/src/new.rs 88.00% 0 Missing and 3 partials ⚠️
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   70.33%   70.37%   +0.03%     
==========================================
  Files          53       53              
  Lines        9098     9123      +25     
  Branches     9098     9123      +25     
==========================================
+ Hits         6399     6420      +21     
  Misses       1718     1718              
- Partials      981      985       +4     
Files with missing lines Coverage Δ
crates/pop-contracts/src/templates.rs 98.24% <100.00%> (ø)
crates/pop-contracts/src/new.rs 82.38% <88.00%> (+0.92%) ⬆️

... and 1 file with indirect coverage changes

@brunopgalvao brunopgalvao self-requested a review October 31, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants