Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra 0x in outputted text when pop up #298

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Conversation

AlexD10S
Copy link
Collaborator

Closes #293

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.23%. Comparing base (e829471) to head (10f2d09).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   70.28%   70.23%   -0.06%     
==========================================
  Files          52       53       +1     
  Lines        8657     9086     +429     
  Branches     8657     9086     +429     
==========================================
+ Hits         6085     6382     +297     
- Misses       1636     1720      +84     
- Partials      936      984      +48     
Files with missing lines Coverage Δ
crates/pop-contracts/src/up.rs 77.40% <100.00%> (+0.16%) ⬆️

... and 10 files with indirect coverage changes

@brunopgalvao brunopgalvao self-requested a review August 29, 2024 17:31
crates/pop-contracts/src/up.rs Outdated Show resolved Hide resolved
@AlexD10S AlexD10S merged commit 1d41cd4 into main Sep 2, 2024
17 of 18 checks passed
@AlexD10S AlexD10S deleted the fix-contracts-up branch September 2, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: extra "0x" in outputted text
2 participants