Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move extract_template_files into common crate #283

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

AlexD10S
Copy link
Collaborator

Refactor the extract_contract_files function, currently used for generating new contract templates in a monorepo with multiple templates, and move it into the pop_common crate.
This will allow us to reuse the function for parachains with the upcoming integrations.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 62.13592% with 39 lines in your changes missing coverage. Please review.

Project coverage is 70.28%. Comparing base (43e4cd0) to head (3636398).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/pop-common/src/templates/extractor.rs 70.31% 0 Missing and 19 partials ⚠️
crates/pop-contracts/src/new.rs 30.00% 6 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/mod.rs 0.00% 4 Missing ⚠️
crates/pop-cli/src/main.rs 0.00% 2 Missing ⚠️
crates/pop-contracts/src/node/mod.rs 50.00% 0 Missing and 2 partials ⚠️
crates/pop-parachains/src/new_pallet.rs 0.00% 0 Missing and 2 partials ⚠️
crates/pop-cli/src/commands/build/spec.rs 0.00% 1 Missing ⚠️
crates/pop-common/src/sourcing/mod.rs 0.00% 1 Missing ⚠️
crates/pop-parachains/src/utils/helpers.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   70.22%   70.28%   +0.06%     
==========================================
  Files          51       52       +1     
  Lines        8673     8657      -16     
  Branches     8673     8657      -16     
==========================================
- Hits         6091     6085       -6     
- Misses       1630     1636       +6     
+ Partials      952      936      -16     
Files Coverage Δ
crates/pop-cli/src/commands/build/contract.rs 61.11% <ø> (ø)
crates/pop-cli/src/commands/build/mod.rs 50.70% <ø> (ø)
crates/pop-cli/src/commands/build/parachain.rs 73.17% <ø> (ø)
crates/pop-cli/src/commands/call/contract.rs 0.00% <ø> (ø)
crates/pop-cli/src/commands/new/contract.rs 48.05% <100.00%> (ø)
crates/pop-cli/src/commands/new/parachain.rs 45.68% <100.00%> (+0.14%) ⬆️
crates/pop-cli/src/commands/up/contract.rs 25.65% <ø> (ø)
crates/pop-cli/src/commands/up/parachain.rs 7.55% <ø> (ø)
crates/pop-cli/src/common/contracts.rs 0.00% <ø> (ø)
crates/pop-common/src/build.rs 100.00% <100.00%> (ø)
... and 23 more

al3mart and others added 2 commits August 23, 2024 16:19
* refactor: directories instead of folders

* style: fmt

* stable fmt
@AlexD10S AlexD10S requested a review from al3mart August 27, 2024 12:54
@AlexD10S AlexD10S merged commit e829471 into main Aug 27, 2024
17 of 18 checks passed
@AlexD10S AlexD10S deleted the alex/refactor-releases branch August 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants