feat: adding new packages to workspace Cargo.toml automatically #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexD10S
requested changes
Aug 7, 2024
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 69.54% 70.12% +0.57%
==========================================
Files 51 51
Lines 8344 8581 +237
Branches 8344 8581 +237
==========================================
+ Hits 5803 6017 +214
- Misses 1591 1610 +19
- Partials 950 954 +4
|
AlexD10S
approved these changes
Aug 8, 2024
tsenovilla
added a commit
to tsenovilla/pop-cli
that referenced
this pull request
Aug 15, 2024
… that's already in the workspace doesn't include it again
AlexD10S
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Interactive interface added * Update pick_options_and_give_name macro to handle an arbitrary amount of cases, allowing pick several options for the same object * New macro for multiselect from an enum. Improve the CLI to support more options * Adding the possibility of using custom origins * Adding Cargo.toml generation * Template lib.rs. Pending of review * Finishing lib (and related) templates * New mock config * Finishing templates * Adding some tests for the folder structure * Formatting repo * Solving mock implementation of common types when no default config issue * Adding more links to Polkadot-SDK-docs * Formatting lib.rs.templ * Solving small issues * Solving doc test issue, the struct used in that test was modified by this PR * Apply suggestions from code review Comment corrections by Bruno Co-authored-by: Bruno Galvao <[email protected]> * Adding simple/advanced modes * Adding advanced mode * Adding advanced mode * Formatting and solving conflicts * Solving small template issues * Formatting the template after generation * Formatting pallet * Updating template generation * Improving manifest test suite * Allowing storage/common_types from CLI + template improvement * Solving bug related to PR #277: Regenerating a crate with POP that's already in the workspace doesn't include it again * Finishing templates with examples; solving some small bugs produced when a pallet is generated from a workspace * Finishing templates with examples; solving some small bugs produced when a pallet is generated from a workspace * Deleting legacy file * Improving UX * Applying suggested changes * Applying suggested changes * Adding a whiteline to lib.rs.templ for formatting, not so important * Not including default config if config trait empty * Improve advanced help examples * Improve advanced help examples * Improve advanced help examples * Applying suggestions --------- Co-authored-by: Bruno Galvao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Cargo.tomlautomatically #275While working in the PR #261 I've been thinking that the feature described in the issue is a must. I took the time to work on a potential solution, hope you find it useful :)