refactor(contracts-node): reduce duplicated code with binary sourcing #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcing to auto-launch contracts-node
AlexD10S
pushed a commit
that referenced
this pull request
Jul 25, 2024
…ts (#254) * feat(contracts-e2e): auto-source contracts-node binary if not present * chore(contract-e2e): deprecate --features e2e-tests * fix: remove unnecessary async function * refactor(contracts-node): reduce duplicated code with binary sourcing (#255) * refactor(up-contract): use Binary struct from parachains -> up -> sourcing to auto-launch contracts-node * refactor(contracts_node): reduce duplicated code -- checkpoint, not working * refactor(contracts_node): use Binary and Source structs for substrate-contracts-node * chore: small changes * chore: small changes * chore: add e2e help, prevent cmd output, and cleanup * refactor(contracts_node): introduce helper to download contracts node if it does not exist * refactor(sourcing): move sourcing functionality to `pop-common` (#258) * refactor(sourcing): move sourcing to pop-common * refactor(sourcing-tests): move sourcing tests to pop-common * refactor(sourcing): better imports * refactor(sourcing): clean sourcing module with better component categorization. Other cleanups * fix: failing tests * fix: needed to download contracts_node for test * fix: add contracts feature, more tests need s c n downloaded * fix: manually create temp dir * fix: append pop_tmp folder in tests * refactor: e2e test improvements (#263) * fix: use async sleep in async context * refactor: remove unnecessary module * refactor: standardise sourcing ux * fix: temp dir issue * chore: component locations, minor improvements --------- Co-authored-by: Frank Bell <[email protected]>
AlexD10S
added a commit
that referenced
this pull request
Jul 26, 2024
…contracts-node` (#262) * feat(contracts-e2e): auto-source contracts-node binary if not present * chore(contract-e2e): deprecate --features e2e-tests * fix: remove unnecessary async function * refactor(contracts-node): reduce duplicated code with binary sourcing (#255) * refactor(up-contract): use Binary struct from parachains -> up -> sourcing to auto-launch contracts-node * refactor(contracts_node): reduce duplicated code -- checkpoint, not working * refactor(contracts_node): use Binary and Source structs for substrate-contracts-node * chore: small changes * chore: small changes * chore: add e2e help, prevent cmd output, and cleanup * refactor(contracts_node): introduce helper to download contracts node if it does not exist * refactor(sourcing): move sourcing functionality to `pop-common` (#258) * refactor(sourcing): move sourcing to pop-common * refactor(sourcing-tests): move sourcing tests to pop-common * refactor(sourcing): better imports * refactor(sourcing): clean sourcing module with better component categorization. Other cleanups * fix: failing tests * fix: needed to download contracts_node for test * refactor: consistency with pop up parachains to recover contracts-node * refactor: improvements * test: unit test for new methods * fix: comment * refactor: remove support for standalone binary * refactor: duplicate code after merge and docs * refactor: remove code from merge * fix: unit test * fix: merge regressions * fix: ui * chore: add license missing in new files * chore: add license missing in new files * refactor: imports * refactor: remove warnings --------- Co-authored-by: Peter White <[email protected]> Co-authored-by: Peter White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the usage of
substrate-contracts-nodeforpop up contractandpop test contract --e2e. These now use the functionality defined inpop-parachainsspecifically for sourcing node-binaries from GitHub.