Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve up ux #248

Merged
merged 3 commits into from
Jul 8, 2024
Merged

refactor: improve up ux #248

merged 3 commits into from
Jul 8, 2024

Conversation

evilrobot-01
Copy link
Contributor

Improves the ux of pop up contract.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 9.34579% with 97 lines in your changes missing coverage. Please review.

Project coverage is 70.32%. Comparing base (e4dc4ed) to head (360d285).

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   70.85%   70.32%   -0.53%     
==========================================
  Files          47       47              
  Lines        7448     7512      +64     
  Branches     7448     7512      +64     
==========================================
+ Hits         5277     5283       +6     
- Misses       1284     1341      +57     
- Partials      887      888       +1     
Files Coverage Δ
crates/pop-contracts/src/build.rs 73.33% <85.71%> (+2.96%) ⬆️
crates/pop-contracts/src/up.rs 77.69% <0.00%> (ø)
crates/pop-cli/src/commands/build/contract.rs 61.11% <33.33%> (+1.11%) ⬆️
crates/pop-contracts/src/utils/contracts_node.rs 62.72% <37.50%> (-1.09%) ⬇️
crates/pop-cli/src/commands/up/contract.rs 20.60% <0.00%> (-7.87%) ⬇️

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, an improvement over existing UX.
I just spotted an error that would be great to address in this PR.

crates/pop-cli/src/commands/up/contract.rs Outdated Show resolved Hide resolved
@AlexD10S AlexD10S merged commit a252c45 into main Jul 8, 2024
13 checks passed
@AlexD10S AlexD10S deleted the frank/up-ux branch July 8, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants