Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable building without project type specification #222

Merged
merged 21 commits into from
Jul 4, 2024
Merged

Conversation

evilrobot-01
Copy link
Contributor

@evilrobot-01 evilrobot-01 commented Jun 25, 2024

Enables building without needing to specify the project type - i.e. pop b -r

TODO:

  • formalise project detection - e.g. reading manifest dependencies properly to check for ink
  • update -p to support package specification, so it can act as a simple wrapper to cargo b -p
  • tests

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 60.75085% with 115 lines in your changes missing coverage. Please review.

Project coverage is 70.40%. Comparing base (9e42df4) to head (81cb96f).

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   70.34%   70.40%   +0.06%     
==========================================
  Files          44       46       +2     
  Lines        6787     7045     +258     
  Branches     6787     7045     +258     
==========================================
+ Hits         4774     4960     +186     
- Misses       1240     1258      +18     
- Partials      773      827      +54     
Files Coverage Δ
crates/pop-common/src/errors.rs 0.00% <ø> (ø)
crates/pop-contracts/src/errors.rs 0.00% <ø> (ø)
crates/pop-parachains/src/errors.rs 0.00% <ø> (ø)
crates/pop-parachains/src/up/mod.rs 88.05% <ø> (+0.05%) ⬆️
crates/pop-cli/src/commands/up/contract.rs 28.47% <0.00%> (ø)
crates/pop-contracts/src/call.rs 69.84% <0.00%> (ø)
crates/pop-contracts/src/utils/helpers.rs 78.72% <50.00%> (ø)
crates/pop-contracts/src/up.rs 77.69% <0.00%> (ø)
crates/pop-cli/src/commands/mod.rs 17.39% <66.66%> (+17.39%) ⬆️
crates/pop-contracts/src/build.rs 70.37% <66.66%> (+70.37%) ⬆️
... and 6 more

Copy link
Collaborator

@brunopgalvao brunopgalvao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. LGTM.

@evilrobot-01 evilrobot-01 marked this pull request as ready for review July 3, 2024 13:25
@evilrobot-01 evilrobot-01 changed the title feat: enable building without project specification feat: enable building without project type specification Jul 3, 2024
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. I just left a few small comments. This will have a lot of conflicts with: #219. If you finish the test, I am happy to merge this first and handle the conflicts myself.

There is no need to include it in this PR. But as a refactor we should remove the short = 'p' in the other commands to maintain consistency and avoid confusing the user.

#[arg(short = 'p', long)]
path: Option<PathBuf>,

And finally, this PR will close #91

crates/pop-cli/src/cli.rs Show resolved Hide resolved
crates/pop-cli/src/commands/build/contract.rs Show resolved Hide resolved
crates/pop-cli/src/commands/build/mod.rs Outdated Show resolved Hide resolved
# Conflicts:
#	crates/pop-contracts/src/errors.rs
@AlexD10S AlexD10S self-requested a review July 4, 2024 13:24
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! LGTM

@AlexD10S AlexD10S merged commit 03639f4 into main Jul 4, 2024
14 of 15 checks passed
@AlexD10S AlexD10S deleted the frank/build branch July 4, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pop Build - Parachain/Contract cargo project detection on current working dir
3 participants