-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(up parachain): faster binary sourcing #199
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 57.25% 65.20% +7.94%
==========================================
Files 34 37 +3
Lines 3701 5069 +1368
Branches 3701 5069 +1368
==========================================
+ Hits 2119 3305 +1186
- Misses 1243 1248 +5
- Partials 339 516 +177
|
d0b0bdc
to
3b3d8db
Compare
Ensures that user is not prompted to update to latest when they have explicitly specified a version to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! pop
now spins up a network quickly and the pop_parachains
crate has excellent test coverage now.
It also closes the issue #176
Only a comment why are we keeping all the .toml files?
No real reason apart from manual testing and examples. I can remove if you want? |
I like to have examples if can help users. My suggestion then will be to add a line in the README or in the docs explaining how to use the examples. Additionally, I recommend renaming all.toml to something more descriptive. |
Done in latest commit |
Introduces the sourcing of prebuilt binaries for supported platforms (aarch64, x64, linux, macos) to avoid the need to compile locally, effectively improving the UX of
pop up
for launching a local network. Also makes use of downloading GitHub source code archives for building rather than cloning as we do not need commit history.Polkadot binaries are provided at https://github.com/r0gue-io/polkadot/releases and are built via a workflow using the release tag used at https://github.com/paritytech/polkadot-sdk/releases.
Also adds Pop Network as a known chain, so users no longer need to specify the -p flag but just use
pop-node
within network config files, as with system parachains. This can be improved in the future to support other chains directly via the same approach as the Templates enum forpop new parachain
, but retaining the-p
option ensures flexibility.Testing
Can be tested on a Apple silicon as follows:
cargo run -- up parachain -f ./tests/networks/pop.toml
rustup target add x86_64-apple-darwin
cargo run --target x86_64-apple-darwin -- up parachain -f ./tests/networks/pop.toml
Kind: Intel
in Activity Monitordocker build -t pop .
docker run -it -v ./tests/networks:/tests/networks --rm --entrypoint bash pop
pop up parachain -f ./tests/networks/pop.toml
docker build --platform linux/amd64 -t pop .
docker run --platform linux/amd64 -it -v ./tests/networks:/tests/networks --rm --entrypoint bash pop
pop up parachain -f ./tests/networks/pop.toml
All the above should also be tested with
--verbose
as well.Remaining tasks: