Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OpenZeppelin template #197

Merged
merged 1 commit into from
Jun 5, 2024
Merged

feat: add OpenZeppelin template #197

merged 1 commit into from
Jun 5, 2024

Conversation

peterwht
Copy link
Contributor

@peterwht peterwht commented Jun 4, 2024

This PR adds support for the OpenZeppelin Generic Polkadot Runtime Template.

Non-audited OpenZeppelin templates are not supported. OpenZeppelin's only release is not in the monorepo format. So, any future releases will need additional changes to support the monorepo.

Co-authored-by: Frank Bell [email protected]

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.58%. Comparing base (4f71822) to head (65777ac).

@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   56.50%   56.58%   +0.08%     
==========================================
  Files          33       33              
  Lines        3504     3513       +9     
  Branches     3504     3513       +9     
==========================================
+ Hits         1980     1988       +8     
- Misses       1231     1232       +1     
  Partials      293      293              
Files Coverage Δ
crates/pop-parachains/src/templates.rs 91.11% <88.88%> (-0.12%) ⬇️

Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@AlexD10S AlexD10S merged commit d977de7 into main Jun 5, 2024
15 checks passed
@AlexD10S AlexD10S deleted the peter/feat-oz branch June 5, 2024 08:56
AlexD10S added a commit that referenced this pull request Jun 5, 2024
AlexD10S added a commit that referenced this pull request Jun 5, 2024
@evilrobot-01 evilrobot-01 restored the peter/feat-oz branch June 5, 2024 10:23
@ozgunozerk
Copy link
Contributor

Looking great to me! Thanks guys ❤️

@ggonzalez94
Copy link

Awesome to see this integration ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants