Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pop install #149

Merged
merged 35 commits into from
May 10, 2024
Merged

feat: pop install #149

merged 35 commits into from
May 10, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented May 8, 2024

pop install command to set up the environment for development by installing required packages.

Closes #110

Next steps can be:

Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I think there are some missing items before this can be merged tho, just so that it is a little more robust in terms of QA and also has a consistent UX with the other commands, as noted.

Note that I do not use brew on mac so have not been able to test it manually there myself, but I did do so in a local Ubuntu container.

.github/workflows/install.yml Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Show resolved Hide resolved
.github/workflows/install.yml Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Outdated Show resolved Hide resolved
.github/workflows/install.yml Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Show resolved Hide resolved
crates/pop-cli/src/main.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed homebrew from machine and tried to build pop cli. Unfortunately I needed cmake which also required me to install homebrew. After installing those I could build pop and run pop install.

The error message regarding cmake:
Screenshot 2024-05-09 at 23 10 35

We should accommodate for homebrew and cmake in the readme

.github/workflows/install.yml Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Outdated Show resolved Hide resolved
@AlexD10S
Copy link
Collaborator Author

AlexD10S commented May 9, 2024

We should accommodate for homebrew and cmake in the readme

This is an error to build pop. I have added a link to the documentation in the README for more information: https://learn.onpop.io/pop/v/pop-cli/welcome/installing-pop-cli

@AlexD10S AlexD10S changed the base branch from pop-install to main May 10, 2024 07:52
@AlexD10S AlexD10S changed the title feat: pop install in rust code feat: pop install May 10, 2024
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few sanity check questions but other than that it LGTM! This is a very important PR, thanks Alex!

Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last minor comments.

crates/pop-cli/src/commands/install/mod.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Show resolved Hide resolved
crates/pop-cli/src/commands/install/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@AlexD10S AlexD10S merged commit cc83f41 into main May 10, 2024
10 checks passed
@AlexD10S AlexD10S deleted the alexd10s/pop-install branch May 10, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pop install
5 participants