-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pop install #149
feat: pop install #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I think there are some missing items before this can be merged tho, just so that it is a little more robust in terms of QA and also has a consistent UX with the other commands, as noted.
Note that I do not use brew on mac so have not been able to test it manually there myself, but I did do so in a local Ubuntu container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an error to build pop. I have added a link to the documentation in the README for more information: https://learn.onpop.io/pop/v/pop-cli/welcome/installing-pop-cli |
2aa892f
to
b40beda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left few sanity check questions but other than that it LGTM! This is a very important PR, thanks Alex!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
pop install
command to set up the environment for development by installing required packages.Closes #110
Next steps can be: