-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable workflows #8
Conversation
b625dc6
to
8b79d05
Compare
I'm seeing an issue using one of the reusable workflows from another repo, due to the use of local action references, so I'm going to hold off merging for now. I'll continue working on this tomorrow -- I see a way forward but will need to tweak things slightly. |
167c02c
to
098d08f
Compare
098d08f
to
d5f6a71
Compare
3677ad6
to
18283bc
Compare
18283bc
to
d9c7286
Compare
d9c7286
to
8b2f4f3
Compare
f66984f
to
2097a0f
Compare
2097a0f
to
c3f6f9f
Compare
Okay, so in testing this PR I hit the following issue: actions/toolkit#1264. Essentially, it means we must be very careful using local actions in workflows intended to be called and used by unrelated remote repos. To work around it, I've had to simplify the workflow and actions so that the workflows call the In addition, the reference in the workflows now contains a
This PR has now diverged quite a bit from |
Fixes #4
Fixes #6
Previously, two actions needed to run in different jobs. To pass information from one job to the next, it required using an
artifact
. The build job required a special GitHub package docker container to run in. It felt like there was a lot of user opportunity to miss a line of code.PR Updates
build-wasm-repository
actiondownload-wasm-artifacts
actionbuild-cran-repo
andbuild-file-system-image
to build a wasm CRAN repo or wasm image bundle.repo-path
orimage-path
respectively.repo-path
defaults to_site
;image-path
defaults to.
.github/actions/build
) that uses a docker file for the single action step. This requires the runner to beubuntu
, but the user can composebuild-repo
orbuild-image
steps how ever they want..github/workflows/release-file-system-image.yml
)packages
input defaults tofile::.
Config/Needs/wasm
is in DESCRIPTION file, those packages are automatically included..github/workflows/deploy-cran-repo.yml
)packages
is empty, then the./packages
file is used as input.Actions in action
Questions
<VERB-THING>
(build-repo
andbuild-image
)build-and-deploy-repo.yml
andrelease-image.yml
)strip
when making a library bundle?