Add global_defer()
#220
Merged
Add global_defer()
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hadley I guess conditioning the global env handling on withr 3.0 is more problematic. |
|
oh but again this only concerns rlang functions, and only when an old version of withr is installed alongside a new rlang, so this shouldn't be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global_defer()is not intended to be used directly but it allows us to move the global handling implementation out of the standalone file.If withr is not available we silently don't run the handlers. This is the same behaviour as
on.exit(). I forgot to check for a sufficient version of withr here but this is dealt with in the last PR of the series.The handlers are now stored in the withr namespace instead of in an attribute of the global environment.
cc @jennybc