Export use_directory() and wrote documentation for it #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Aug 10, 2017
R/helpers.R
Outdated
| #' | ||
| #' @return `TRUE` (invisibly) if the directory was successfully created. | ||
| #' | ||
| #' @inheritParams use_template |
R/helpers.R
Outdated
| #' package root dir. This function powers many of the other `use_` functions | ||
| #' such as [use_data()] and [use_vignette()]. | ||
| #' | ||
| #' @return `TRUE` (invisibly) if the directory was successfully created. |
There was a problem hiding this comment.
I think you can leave this off. I'd rather do it for all function in one swoop
Closed
|
Hmm im kinda new to this. To me it shows two commits for the pull request now: the initial one, and the one that adds documentation for path and adds the NEWS.md bullet point. |
|
Hmmm, now it looks mostly ok. I'll finish off the process. Thanks! |
|
Ok thanks, no idea what went wrong on the initial push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.