Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assist with Quarto vignettes and articles #2085

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Nov 22, 2024

Closes #1997

@jennybc jennybc requested review from hadley and cderv November 22, 2024 17:36
@jennybc
Copy link
Member Author

jennybc commented Nov 22, 2024

@hadley @cderv I'm going to tackle use_article() now and I need to exercise this a bit more. done now

But I need to release usethis in the next week, so I'd like to invite feedback based on what you see here now. You should be able to get the general idea.

@hadley I know we talked about the interface a while back. I hope I've done what we discussed, i.e. inferring Rmd vs. qmd from the name.

@cderv I'm especially interested in you looking at whether I've got the DESCRIPTION, gitignores, and Rbuildignores rigged the way they should be.

Thanks in advance!

@jennybc jennybc mentioned this pull request Nov 22, 2024
@jennybc
Copy link
Member Author

jennybc commented Nov 23, 2024

Suffering from this beyond-my-control problem on macOS GHA:

Error: Failed to get R release: Failed to get R 4.4.2: Failed to install qpdf: Error: The process '/opt/homebrew/bin/brew' failed with exit code 1

@jennybc jennybc marked this pull request as ready for review November 23, 2024 16:43

use_git_ignore(c("*.html", "*.R"), directory = target_dir)
if (ext == "qmd") {
use_git_ignore("**/.quarto/")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will gitignore .quarto at the top-level (relevant to README.qmd, although usethis isn't helping to place such a file just yet), vignettes/.quarto (normal vignettes), and vignettes/articles/.quarto (articles). It's probably redundant with something Quarto itself is doing, but I think this is better than what Quarto does and redundancy is not a big deal in this context.

@jennybc jennybc merged commit d7bf1cc into main Nov 25, 2024
13 of 14 checks passed
@jennybc jennybc deleted the qmd-vignette-article branch November 25, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should use_vignette support quarto?
1 participant