Rationalize nested projects #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1643 We discourage nested projects, but it is possible, mostly for developers. So we should at least behave correctly in this code path. Previously, a nested project would put the name of the parent project in DESCRIPTION, which causes a variety of downstream problems.
|
@lionel- I think this should solve your problem and this is my preferred solution. |
lionel-
reviewed
Jun 11, 2022
Useful in tests (replaces the mock) and also to a developer, like @lionel-, who might need to do this often enough to set the option.
OK now this PR will honour the undocumented option used in your PR (and I'm using that in the usethis tests instead of a mock). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1643
We discourage nested projects, but it is possible, mostly for developers. So we should at least behave correctly in this code path.
Previously, a nested project would put the name of the parent project in DESCRIPTION, which causes a variety of downstream problems. The
.Rprojfile gets the wrong name. Every call toproject_name()returns the wrong name.Also, when
proj_set(force = TRUE), we should bypass the initial early return if we discover that we are already in a project. The whole point offorce = TRUEis to do exactly as we are told. This was causing the active project to be still be set to the parent, when trying to work with a nested project.