Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pkg installed before adding to rprofile #1398

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Check pkg installed before adding to rprofile #1398

merged 3 commits into from
Apr 16, 2021

Conversation

malcolmbarrett
Copy link
Collaborator

This PR adds check_installed() to use_rprofile_package(), something that I bumped into recently while iterating through a few different clean environments. rlang::check_installed() is just so dang helpful that I think it makes sense to check!

@hadley
Copy link
Member

hadley commented Apr 16, 2021

Looks good — can you please add a NEWS bullet?

@hadley hadley merged commit 23759f0 into r-lib:master Apr 16, 2021
@hadley
Copy link
Member

hadley commented Apr 16, 2021

Thanks @malcolmbarrett!

@malcolmbarrett malcolmbarrett deleted the check_installed_rprofile branch April 16, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants