Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only disable crayon for individual tests #1226

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Only disable crayon for individual tests #1226

merged 1 commit into from
Sep 23, 2020

Conversation

hadley
Copy link
Member

@hadley hadley commented Sep 23, 2020

Turned out to be simpler than I expected, and I think the payoff (nicely coloured tests) is worth it. The only minor head scratcher was finding the on.exit() with missing add = TRUE.

@hadley hadley requested a review from jennybc September 23, 2020 12:16
@jennybc
Copy link
Member

jennybc commented Sep 23, 2020

When I merge the giant PR I'm working on, I'm going to systematically eliminate all on.exit() calls (#1217)!

@jennybc jennybc merged commit 73a4a09 into master Sep 23, 2020
@jennybc jennybc deleted the colour branch September 25, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants