Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up: Standalone should not be styled #1135 #1138

Merged
merged 4 commits into from
Sep 24, 2023
Merged

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Jul 16, 2023

Closes #1134. Superceeds #1135.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if acd0b46 is merged into main:

  •   :ballot_box_with_check:cache_applying: 223ms -> 225ms [-1.58%, +2.91%]
  •   :ballot_box_with_check:cache_recording: 737ms -> 741ms [-0.14%, +1.28%]
  •   :ballot_box_with_check:without_cache: 1.39s -> 1.39s [-0.32%, +0.93%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert marked this pull request as ready for review July 16, 2023 18:41
@lorenzwalthert
Copy link
Collaborator Author

@IndrajeetPatil only if you have time, no worries otherwise.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #1138 (ea1996b) into main (957d64f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ea1996b differs from pull request most recent head 30e8f15. Consider uploading reports for the commit 30e8f15 to get more accurate results

@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
+ Coverage   92.33%   92.35%   +0.01%     
==========================================
  Files          46       46              
  Lines        2650     2654       +4     
==========================================
+ Hits         2447     2451       +4     
  Misses        203      203              
Files Changed Coverage Δ
R/ui-styling.R 100.00% <100.00%> (ø)

@lorenzwalthert lorenzwalthert merged commit 12f7eb6 into main Sep 24, 2023
18 checks passed
@lorenzwalthert lorenzwalthert deleted the standalone branch September 24, 2023 09:11
@lorenzwalthert
Copy link
Collaborator Author

Thanks @IndrajeetPatil.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 957d64f is merged into main:

  •   :ballot_box_with_check:cache_applying: 282ms -> 284ms [-0.22%, +1.74%]
  •   :ballot_box_with_check:cache_recording: 838ms -> 841ms [-0.37%, +1.02%]
  •   :ballot_box_with_check:without_cache: 1.52s -> 1.52s [-0.84%, +0.27%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standalone files imported from other packages should be ignored in style_pkg()
4 participants