Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing dplyr and possibly purrr dependencies? #181

Closed
jimhester opened this issue Sep 5, 2017 · 7 comments
Closed

Consider removing dplyr and possibly purrr dependencies? #181

jimhester opened this issue Sep 5, 2017 · 7 comments
Assignees

Comments

@jimhester
Copy link
Member

dplyr is a very heavy dependency which makes using styler on CI services such as travis or appveyor problematic.

Doing this would be useful so you could style the package as a CI step and ensure there are no changes as a way to verify that PRs conform to the style. But this will only work well if styler has limited (and light) dependencies.

If you are open to the possibility of removing the dependency I could work on a PR.

@krlmlr
Copy link
Member

krlmlr commented Sep 5, 2017

I think removing dplyr and using compat-purrr.R is a good plan. Happy to review a PR.

@lorenzwalthert
Copy link
Collaborator

I think since I know the project fairly well by now, I can start working on this in about two weeks if @jimhester is ok with that. If I remember correctly, the majority of dplyr calls was already removed with #90, so it should not be too much of work.

@jimhester
Copy link
Member Author

I have a WIP at #182.

I also realized that tidyr also has a dplyr dependency, so we would need to remove tidyr as well.

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Sep 5, 2017

Yes, that might be tricky. Especially for creating the nested parse data - as the name says - we heavily rely on tidyr::nest().

jimhester added a commit to jimhester/styler that referenced this issue Sep 5, 2017
jimhester added a commit to jimhester/styler that referenced this issue Sep 5, 2017
@jimhester
Copy link
Member Author

tidyr wasn't bad #183

@jimhester
Copy link
Member Author

dplyr (#182) is complete now as well. Purrr is fairly light these days, we can remove it if we want, but probably not really needed.

jimhester added a commit to jimhester/styler that referenced this issue Sep 15, 2017
jimhester added a commit to jimhester/styler that referenced this issue Sep 15, 2017
jimhester added a commit to jimhester/styler that referenced this issue Sep 15, 2017
jimhester added a commit to jimhester/styler that referenced this issue Sep 15, 2017
@krlmlr
Copy link
Member

krlmlr commented Sep 15, 2017

Should be good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants