-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing dplyr and possibly purrr dependencies? #181
Comments
I think removing dplyr and using compat-purrr.R is a good plan. Happy to review a PR. |
I think since I know the project fairly well by now, I can start working on this in about two weeks if @jimhester is ok with that. If I remember correctly, the majority of dplyr calls was already removed with #90, so it should not be too much of work. |
I have a WIP at #182. I also realized that tidyr also has a dplyr dependency, so we would need to remove tidyr as well. |
Yes, that might be tricky. Especially for creating the nested parse data - as the name says - we heavily rely on |
Fixes part of r-lib#181
Fixes part of r-lib#181
tidyr wasn't bad #183 |
dplyr (#182) is complete now as well. Purrr is fairly light these days, we can remove it if we want, but probably not really needed. |
Fixes part of r-lib#181
Fixes part of r-lib#181
Fixes part of r-lib#181
Fixes part of r-lib#181
Should be good now. |
dplyr is a very heavy dependency which makes using styler on CI services such as travis or appveyor problematic.
Doing this would be useful so you could style the package as a CI step and ensure there are no changes as a way to verify that PRs conform to the style. But this will only work well if styler has limited (and light) dependencies.
If you are open to the possibility of removing the dependency I could work on a PR.
The text was updated successfully, but these errors were encountered: