-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve version requirements in is_installed()
and check_installed()
#1332
Conversation
@hadley In pkgload, a failing version requirement only issues a warning instead of an error, this way the package can be loaded anyway. I just want to check this is still the behaviour we want to support since that might be slightly tricky to implement. (Probably we need to signal a classed condition before calling |
In pkgload, I think we can just protect with some |
Oh but the idea is to now use |
f3dda79
to
20ad93e
Compare
377dd6f
to
c6a47f8
Compare
ok cool, that will make things simpler! We now take an optional |
This reverts commit 3101076.
c6a47f8
to
934f082
Compare
934f082
to
aca1968
Compare
Branched from #1331.
is_installed("rlang (>= 1.0.0)"
.compare
argument to supply requirement info programmatically.<
or<=
is used,check_installed()
doesn't prompt for install.This will allow support for
check_installed()
in pkgload, so that we get install prompts on missing deps.