Add legacy support for peek_option("rlang:::message_always")
#1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1188 removed support for
rlang:::message_always.Currently, CRAN version of
shinyhas a test that is using this option. The test has been updated rstudio/shiny#3379 for the next regular release of shiny.I suggested a date of 2022. Shiny should be released by then. Feel free to change the comment / time.
If you'd rather not take the PR, we could make a patch release for
shinyto disable the test. I'd prefer to not go down that route.Thank you!
cc @cpsievert