respect auth_token=NULL when used in install_github() #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#818 SAML sign-on behavior with GitHub Enterprise makes
install_github()impossible to use for GitHub repos on Enterprise accounts with multiple orgs. Users on one org will be unable to install R packages in public repos on other orgs in the Enterprise account. If remotes would respectauth_token=NULLthen that can be put in the install instructions.Currently when you use
install_github(..., auth_token=NULL), remotes does not fully respect the 'request' not to use a PAT and not to usegithub_pat(). The call togithub_pat()(instead of using NULL that was passed in) happens in 2 places.The changes suggested cause
auth_token=NULLto be used consistently, as if there were no PAT at all (which is what is being requested.Since NULL is what
github_pat()returns if there is no PAT stored, it seems like this does not break anything. It simply respectsauth_token=NULL.