Unadvertised SHAs don't work for github/bitbucket #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muschellij2
changed the title
|
Killing this PR - but may be good to have a warning if "like" a short SHA? |
|
This still does have an issue as the Line 202 in eb15a1e archive and this is an issue for bitbucket and github as well.
|
|
@muschellij2 I am sorry, I forgot, is this still an issue, or using the full sha solves your problems? |
|
I believe it does, but do you think this solution would save some users who
put a short SHA? Or maybe put a short SHA check with GH or bitbucket?
On Wed, Feb 2, 2022 at 3:27 AM Gábor Csárdi ***@***.***> wrote:
@muschellij2 <https://github.com/muschellij2> I am sorry, I forgot, is
this still an issue, or using the full sha solves your problems?
—
Reply to this email directly, view it on GitHub
<#675 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIGPLXBO3MN2KIO5M53MFLUZDTIZANCNFSM5JIEOZJQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Best,
John
|
|
You are right that a full clone would save some users, but it would also cause pain to other users, when installing from large repos. Popular packages often have large repos, e.g. ggplot2, etc. I think if the short sha is not found, then we could include a tip in the error message, suggesting a full sha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #674. I know it's heavy handed in the sense that github/bitbucket git repos are going full depth, but otherwise you can't use SSH with
install_gitto specific SHAs.The use case is using SSH keys (as opposed to GITHUB_PAT for a number of reasons) and you want to install specific references of packages for a reproducible environment.
git fetch origin SHAwon't work for these.