Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spaces around infix operator ^ #321

Merged
merged 5 commits into from
Jun 6, 2018
Merged

Remove spaces around infix operator ^ #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a26dc7
fix: Remove ^ from infix spaces to conform with tidyverse. Fixes #302
Mar 12, 2018
32951b1
test: Remove redundant test (linked to 715f005)
Mar 12, 2018
5182418
Merge remote-tracking branch 'upstream/master'
Mar 23, 2018
eb76601
Merge branch 'master' of https://github.com/jimhester/lintr
dchiu911 May 30, 2018
776ae1c
** is translated in the parser to ^
dchiu911 May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
* # nolint comments are respected with caching (#68, @krlmlr)
* Properly handle all knitr document formats
* Allow for (( when linting (#259, @nathaneastwood)
* Remove ^ from infix spaces to conform with tidyverse. (#302, @nathaneastwood)

# lintr 0.2.0 #

Expand Down
1 change: 0 additions & 1 deletion R/infix_spaces_linter.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ infix_tokens <- c(
"EQ_SUB",
"SPECIAL",
"'/'",
"'^'",
"'*'",

NULL
Expand Down
2 changes: 0 additions & 2 deletions tests/testthat/test-infix_spaces_linter.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ test_that("returns the correct linting", {
"->",
"%%",
"/",
"^",
"*",
"**",
"|",
"||",
"&",
Expand Down