Make spaces_left_parentheses_linter more robust when determining ( type
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it has been made smarter in determing whether ( belongs to a function call
| # only look terminal tokens | ||
| terminal_types <- before_parsed[before_parsed$terminal, "token"] | ||
| # find the type of last such token | ||
| type <- terminal_types[length(terminal_types)] |
There was a problem hiding this comment.
Maybe change this to
last_type <- tail(terminal_types, n = 1)Which might make it more explicit so a comment is unnecessary.
|
Thanks for the suggestion @jimhester. I have made corresponding changes. I have also added |
|
Looks great, thanks! |
jimhester
added a commit
that referenced
this pull request
Dec 29, 2015
Make spaces_left_parentheses_linter more robust when determining `(` type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
spaces_left_parentheses_lintercontains false negatives when it comes towhere
if,for,whileblocks could contain function calls.It seems to me that we can improve this linter by stricter checking on the type of
('s owner. Previously if the line has any function calls, we completely let it go.I have also incorporated the improved linter's suggestions in this PR. Hope that is okay.
Finally I'm not very familiar with this package yet. So definitely let me know if you see any concerns or potential improvements of my PR.