-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Mac M1 support #365
base: main
Are you sure you want to change the base?
Fixed Mac M1 support #365
Conversation
Fixed a issue r-lib#348 by importing the latest config.sub from https://git.savannah.gnu.org/cgit/config.git/plain/config.sub.
Looks like this built ok... Is this ready to merge? |
This pr not updated config.guess. It will fail when build for loongarch64 CPU. @yoshimoto |
@cheungxi Thank you. I've updated both of config.guess and config.sub. However, the check on ubuntu-18.04 (oldrel-4) seems to have failed. Is this an another issue or not? |
why no people review this pr ? |
Looks like there's one error in one build:
I'm not sure what would cause that error... |
I re-ran the check and all tests have passed now. For your information, I ran the check three times via same code, and got three different results: |
Can merge to master ? @gaborcsardi |
Fixed a issue #348 by importing the latest config.sub from
https://git.savannah.gnu.org/cgit/config.git/plain/config.sub.