[my_unzip] add exception #1678
Merged
[my_unzip] add exception #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever R is compiled with no 'unzip' package installed in the underlying operation system, the getOption( 'unzip' ) variable is set to an empty string. (At least for R-3.4.0 on a vanilla Ubuntu16.04 Since the empty string doesn't trigger the if clause and its usage of the R interal utils::unzip function, I added another exception.
|
Thanks! This is fine, you just need to use the non-vectorized Make that change and add a note to NEWS.md mentioning this change, the PR number and your GitHub handle and I can merge this. |
In addition to the previous commit a non-vectorized 'or' is used within the my_unzip function. The changes have been added to the NEWS.md
|
Alright, done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever R is compiled with no 'unzip' package installed in the underlying operation system, the getOption( 'unzip' ) variable is set to an empty string. (At least for R-3.4.0 on a vanilla Ubuntu16.04
Since the empty string doesn't trigger the if clause and its usage of the R interal utils::unzip function, I added another exception.