-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be less aggressive about documenting in check() #2263
Comments
I really think it would be better to not run |
I think I agree that we shouldn’t have done this in the first place. But I’m concerned that if we change it now it’s going to cause a lot of unpleasant surprises for people so we need to figure out some compromise position. |
I think your idea of only rebuilding if the roxygen version matches is a good compromise. |
Not sure how to detect this, but when you’re doing a PR to someone else’s repo, it’s annoying that check documents and introduces a bunch of spurious changes.
Maybe a reasonable heuristic is to only rebuild if roxygen version is the same, otherwise emit a very clear warning.
The text was updated successfully, but these errors were encountered: