Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider throwing an error when build_manual() fails #2056

Closed
jolars opened this issue Jun 5, 2019 · 4 comments
Closed

Consider throwing an error when build_manual() fails #2056

jolars opened this issue Jun 5, 2019 · 4 comments

Comments

@jolars
Copy link

jolars commented Jun 5, 2019

Currently, there is no nothing to let you know that something went wrong during compilation of the package manual when build_manual() is called. The only difference from a successful call is that the two last lines of output are missing

Successfull call to build_manual():

Hmm ... looks like a package
Creating pdf output from LaTeX ...
Saving output to ‘[some-file-name].pdf...
Done

Failing call to build_manual():

Hmm ... looks like a package
Creating pdf output from LaTeX ...

May I suggest that, at the very least, the function throws an error saying something went wrong in building the manual.

@jimhester
Copy link
Member

Do you have an example package where the manual fails to build?

@jolars
Copy link
Author

jolars commented Jun 5, 2019

Sure, here's an example: https://github.com/jolars/testr

@jimhester
Copy link
Member

Ok we now fail in this case, thanks for opening the issue and making the example package!

HughParsonage pushed a commit to HughParsonage/devtools that referenced this issue Jul 2, 2019
@lock
Copy link

lock bot commented Dec 2, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants