Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated URLWhitelist #1288

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Replaced deprecated URLWhitelist #1288

merged 3 commits into from
Dec 10, 2024

Conversation

Vzor-
Copy link
Contributor

@Vzor- Vzor- commented Aug 28, 2024

Partially addresses/related to #1277

@tresf

This comment was marked as outdated.

@tresf
Copy link
Contributor

tresf commented Aug 29, 2024

I tested this on Windows 11 ARM64 and the popup still shows.

image

@tresf tresf self-requested a review August 29, 2024 16:00
Copy link
Contributor

@tresf tresf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are needed; seems to still be broken on Windows.

@Vzor-
Copy link
Contributor Author

Vzor- commented Aug 29, 2024

This is a working policy on MacOS
Screenshot 2024-08-29 at 2 03 14 PM
this is a not working policy on Windows.
Screenshot 2024-08-29 at 2 04 01 PM
They seem similar, but there are some minor discrepancies. I'll try resolving these to find the issue.

@tresf
Copy link
Contributor

tresf commented Nov 7, 2024

@Vzor- based on our conversations, I believe you found an upstream bug here but QZ's downstream bug report was never updated to reflect it. Furthemore, I do not believe that an upstream bug report was ever filed to accompany this downstream bug. Can you please provide your findings so that we can take action on this?

@Vzor-
Copy link
Contributor Author

Vzor- commented Nov 11, 2024

Certainly. I was in the middle of testing a possible solution when I had to jump to a more pressing issue. This will be the next issue I start.

@tresf
Copy link
Contributor

tresf commented Dec 10, 2024

Certainly. I was in the middle of testing a possible solution when I had to jump to a more pressing issue. This will be the next issue I start.

It's been a month and the upstream bug/upstream bug report still isn't mentioned here or in #1277. For sake of completeness, I'm going to change the wording of this PR from "fixes" to "related", merge and paste your screenshot over there. Please provide the details that you gathered researching this problem to #1277 so that we can determine next actions.

@tresf tresf merged commit 159eb92 into qzind:master Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants