-
Notifications
You must be signed in to change notification settings - Fork 20
Exponential back off & Mask secrets from log #43
Conversation
The fail is due to GitHub rate limit and not due to the PR to the best of my understanding. Will close/reopen to force re-run. It appears to be a Travis CI Mac OS API rate issue, similar post: actions/runner-images#602 |
Hi @svyotov, thanks for opening a PR for this! I would be happy to add the ability to retry on errors and use exponential back-off for this 🙂 There is only one issue I see with the current state of the PR: The PR introduces a 3rd-party dependency. For now ghbackup didn't need any 3rd-party library. Since exponential back-off is not a complex algorithm I would rather not introduce an external library for this. If you could change that, I would be happy to merge this :) |
👍 done |
I would merge this now if you don't mind :) |
ok, there is a new release now including this PR: https://github.com/qvl/ghbackup/releases/tag/v1.13.0 |
newExponentialBackOff
for clone operations (we have observed frequent DNS/network issues with GitHub - easy to recover from with a retry)