-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1208 Test #106
base: master
Are you sure you want to change the base?
Issue #1208 Test #106
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. Please can you:
- add qutip.about or table at the end of the notebook
QObj
->Qobj
- fundamentals-> fundamental
- if you know it, could you add some context or examples about the S and T gates?
- can you please place the example under the
qip
module section in the qutip.github.io repository in the tutorials.html page? you just need to copy-paste the link of the ipynb notebook in that html page.
https://github.com/qutip/qutip.github.io
Hi @nathanshammah, besides applying each change required, I also create a stronger notebook with some more theory about qubits and single-qubit gates. Take a look and let me know what you think. About adding the link to the tutorials.html doc, it's not possible since this PR has not been merged yet, so the link of the notebook is still in my localhost. The name of the notebook was also changed to Theory of Qubits and Single Quantum Gates.ipynb. |
Sorry for the delay. The notebook looks good! Thanks @mlaguna10. What I'm not sure about is where shall we put it? As a stand-long notebook, only mentioning the single-qubit gates makes the story kind of incomplete to me. And it partially overlaps with the long notebook of quantum gates Quantum Gates and their usage. What about
Later, we
What is your mind on this? @nathanshammah @quantshah |
That sounds great and I'd love to take care of completing this whole plan. I will be aware of what @nathanshammah and @quantshah think to start working on this. |
@BoxiLi Just pinging this PR -- should we merge? Not merge? |
Notebook testing changes made under issue #1208.
Pauli-X, Y, Z and S,T Quantum Gates using QuTiP: new functions added under issue #1208 are documented in this notebook.