Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1208 Test #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #1208 Test #106

wants to merge 2 commits into from

Conversation

mlaguna10
Copy link

Notebook testing changes made under issue #1208.

Pauli-X, Y, Z and S,T Quantum Gates using QuTiP: new functions added under issue #1208 are documented in this notebook.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Please can you:

  • add qutip.about or table at the end of the notebook
  • QObj->Qobj
  • fundamentals-> fundamental
  • if you know it, could you add some context or examples about the S and T gates?
  • can you please place the example under the qip module section in the qutip.github.io repository in the tutorials.html page? you just need to copy-paste the link of the ipynb notebook in that html page.
    https://github.com/qutip/qutip.github.io

@nathanshammah nathanshammah requested a review from BoxiLi March 28, 2020 18:00
@mlaguna10
Copy link
Author

mlaguna10 commented Apr 1, 2020

Hi @nathanshammah, besides applying each change required, I also create a stronger notebook with some more theory about qubits and single-qubit gates. Take a look and let me know what you think.

About adding the link to the tutorials.html doc, it's not possible since this PR has not been merged yet, so the link of the notebook is still in my localhost.

The name of the notebook was also changed to Theory of Qubits and Single Quantum Gates.ipynb.

@BoxiLi
Copy link
Member

BoxiLi commented Apr 25, 2020

Sorry for the delay. The notebook looks good! Thanks @mlaguna10.

What I'm not sure about is where shall we put it? As a stand-long notebook, only mentioning the single-qubit gates makes the story kind of incomplete to me. And it partially overlaps with the long notebook of quantum gates Quantum Gates and their usage.

What about

  • we merge this notebook first

Later, we

  • Split the long notebook into a gate part and a circuit part
  • Create a more complete story using this notebook and the gate part of the long notebook

What is your mind on this? @nathanshammah @quantshah

@mlaguna10
Copy link
Author

Sorry for the delay. The notebook looks good! Thanks @mlaguna10.

What I'm not sure about is where shall we put it? As a stand-long notebook, only mentioning the single-qubit gates makes the story kind of incomplete to me. And it partially overlaps with the long notebook of quantum gates Quantum Gates and their usage.

What about

  • we merge this notebook first

Later, we

  • Split the long notebook into a gate part and a circuit part
  • Create a more complete story using this notebook and the gate part of the long notebook

What is your mind on this? @nathanshammah @quantshah

That sounds great and I'd love to take care of completing this whole plan. I will be aware of what @nathanshammah and @quantshah think to start working on this.

@hodgestar
Copy link
Contributor

@BoxiLi Just pinging this PR -- should we merge? Not merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants