Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

ui improvements for share and side bar #895

Merged
merged 7 commits into from
Nov 29, 2017
Merged

Conversation

thabti
Copy link
Contributor

@thabti thabti commented Nov 19, 2017

Title of change

UI improvements for share and side bar

share

radio

Checklist

  • Unit tests written
  • Manually tested
  • New dependencies were added with yarn
  • Prettier & ESLint were run

Screenshot

insert screenshot if needed

@thabti
Copy link
Contributor Author

thabti commented Nov 19, 2017

rebuild

@mmahalwy
Copy link
Contributor

rebuild

1 similar comment
@naveed-ahmad
Copy link
Contributor

rebuild

@thabti
Copy link
Contributor Author

thabti commented Nov 23, 2017

@ahmedre jenkins :(

@mmahalwy
Copy link
Contributor

rebuild

2 similar comments
@naveed-ahmad
Copy link
Contributor

rebuild

@naveed-ahmad
Copy link
Contributor

rebuild

@ahmedre
Copy link
Contributor

ahmedre commented Nov 28, 2017

Deployed to: http://staging.quran.com:32877

@ahmedre
Copy link
Contributor

ahmedre commented Nov 28, 2017

Deployed to: http://staging.quran.com:32878

@naveed-ahmad
Copy link
Contributor

naveed-ahmad commented Nov 29, 2017

There is no sidebar on staging for now, so no way to test this. Going to merge this, need to move on!

@naveed-ahmad
Copy link
Contributor

rebuild

1 similar comment
@naveed-ahmad
Copy link
Contributor

rebuild

@ahmedre
Copy link
Contributor

ahmedre commented Nov 29, 2017

Deployed to: http://staging.quran.com:32885

@naveed-ahmad naveed-ahmad merged commit 1f09a5a into master Nov 29, 2017
@naveed-ahmad naveed-ahmad deleted the ui-improvements branch November 29, 2017 20:13
@thabti
Copy link
Contributor Author

thabti commented Nov 30, 2017

thank you @naveed-ahmad

dependabot bot added a commit that referenced this pull request Jul 27, 2020
ui improvements for share and side bar
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants