This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Remove "The play() request was interrupted by a call to pause()" #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:32929 |
| const playPromise = currentFile.play(); | ||
| // Catch/silence error when a pause interrupts a play request | ||
| // on browsers which return a promise | ||
| if (playPromise !== undefined && typeof playPromise.then === 'function') { |
There was a problem hiding this comment.
What about playPromise && playPromise.then ? less code fewer bugs :)
There was a problem hiding this comment.
yes, could have done that 👍
naveed-ahmad
approved these changes
Jul 31, 2017
|
Heads up @naveed-ahmad @mannanali413 i am doing a little rewrite of audioplayer. going to push soon |
|
Well, I think this bug is not yet fixed. I can't succeed playing the next verse and this error still appear. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request is addressed to close the issue raised here
On Chrome, the
play()method on an HTML Media Element returns a promise.Since, the play method is asynchronous, if
pause()method is called/triggered while a call toplay()is in progress, Chrome throws an error statingThe play() request was interrupted by a call to pause()The error thrown by Chrome doesn't break anything, it is just logged on the console.
On Browsers that return a promise, we can chain the play promise to catch any errors and ignore them.