Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Implement sw-precache-webpack-plugin (WIP) #837

Closed
wants to merge 1 commit into from

Conversation

agungsb
Copy link

@agungsb agungsb commented Jun 28, 2017

I've tried to implement sw-precache-webpack-plugin to provide Progressive Web App feature. Unfortunately, the plugin currently doesn't support webpack-dev-server (explained here). So it has to be run in production environment.

Since I can't run npm start (is there anyway to run as production?), so I couldn't check any further from my local whether the service worker is already set properly or not. But current implementation should at least let the service worker registered.

@naveed-ahmad
Copy link
Contributor

rebuild

@agungsb
Copy link
Author

agungsb commented Jun 29, 2017

Hi, any follow up on this PR? It seems like there's a problem with Webpack and Karma.

@thabti
Copy link
Contributor

thabti commented Jun 29, 2017

@agungsb

you have some linting errors, please run npm run lint:fix or try to fix the errors manually.

/home/travis/build/quran/quran.com-frontend/src/registerServiceWorker.js
  14:67  error    'navigator' is not defined                                   no-undef
  17:7   error    'navigator' is not defined                                   no-undef
  20:11  error    Assignment to property of function parameter 'registration'  no-param-reassign
  24:21  error    'navigator' is not defined                                   no-undef
  29:19  warning  Unexpected console statement                                 no-console
  34:19  warning  Unexpected console statement                                 no-console
  41:11  warning  Unexpected console statement                                 no-console
  48:26  error    'navigator' is not defined                                   no-undef
  49:5   error    'navigator' is not defined       

@naveed-ahmad
Copy link
Contributor

sw-precache is deprecated, let's use workbox instead.

@ahmedre
Copy link
Contributor

ahmedre commented Nov 16, 2017

Deployed to: http://staging.quran.com:32873

@mmahalwy
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants