This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Simple refactorizations. #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 9, 2017 11:05
Replace `var` with `const` where necessary. Remove unnecessary semicolons in some places. Add semicolons in some places. General style refactorizations.
|
Deployed to: http://staging.quran.com:32847 |
|
I think changes to |
|
Deployed to: http://staging.quran.com:32848 |
|
Undoing those changes fixes it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assalamu Alaikum
This PR contains simple refactorizations, mostly recommended by ESLint. It's a basic starting point for me to delve into something a little deeper and help contribute.
It contains, as the commits note:
pxor%qualifiers on values of 0 throughout.scssfiles. (@b13826e)varwithconstwhen it makes sense to do so (same withlet->const). (@4e6ea55)P.S. I've not done proper local testing with this yet -- having some issues with setting up a local environment right now, and a little busy with work preventing me from solving that. Just wanted to get this PR up. Hopefully CI can give us the confidence we need.